Skip to content

Conversation

@AaronHForgeFlow
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow force-pushed the 19.0-add-sale_order_approval_block branch from bdf1030 to 4e251ef Compare January 8, 2026 14:20
@AaronHForgeFlow AaronHForgeFlow force-pushed the 19.0-add-sale_order_approval_block branch from 4e251ef to e3730ae Compare January 8, 2026 14:56
@rousseldenis rousseldenis modified the milestones: 18.0, 19.0 Jan 8, 2026
@rousseldenis
Copy link
Contributor

@AaronHForgeFlow So, we agree this is not the same as : https://github.com/OCA/sale-workflow/tree/17.0/sale_tier_validation ?

@AaronHForgeFlow
Copy link
Contributor Author

@rousseldenis This module focuses more on the blocking of wrong orders and not on the validation process. It will be used mainly:

  • To prevent mistakes when entering the quantities and price units
  • To prevent sale users to confirm sales that are not profitable enough for some reason.

The release of the blocking will not be the most common use case but the correction of the sales order.



class TestSaleOrderApprovalBlock(TransactionCase):
def setUp(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use class method instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants